Update site.py #2306
Merged
Update site.py #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed --db-name ignoring when creating new-site
|
@vbaidak have you tried this locally? (I am pretty sure |
|
Hi. Agree. I'm not a Python guru I faced with this issue and this is the place that seems to be causing it. The problem is that None is passed as an argument instead of real db-name, which is provided. I don't know how to pass this variable from the annotation. May be you could help? |
|
@vbaidak try editing this file locally and check if this work. This certainly won't work |
rmehta
requested changes
Nov 14, 2016
| @@ -22,7 +22,7 @@ def new_site(site, mariadb_root_username=None, mariadb_root_password=None, admin | |||
| "Create a new site" | |||
| frappe.init(site=site, new_site=True) | |||
|
|
|||
| _new_site(None, site, mariadb_root_username=mariadb_root_username, mariadb_root_password=mariadb_root_password, admin_password=admin_password, | |||
| _new_site(db-name, site, mariadb_root_username=mariadb_root_username, mariadb_root_password=mariadb_root_password, admin_password=admin_password, | |||
| verbose=verbose, install_apps=install_app, source_sql=source_sql, force=force) | |||
Fixed --db-name ignoring when creating new-site
|
Hi! Many thanks! I've checked it locally, it works now |
rmehta
approved these changes
Dec 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed --db-name ignoring when creating new-site