feat: Allow usage of print() within safe_exec()
#23084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilnarang
requested review from
a team and
surajshetty3416
and removed request for
a team
github-actions
bot
added
the
add-test-cases
akhilnarang
force-pushed
the
restrictedpython-print
branch
from
b2e066a
to
1fc5af6
Compare
akhilnarang
changed the title
print() within safe_eval()print() within safe_exec()
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #23084 +/- ##
===========================================
+ Coverage 62.18% 62.22% +0.03%
===========================================
Files 770 770
Lines 73970 73997 +27
Branches 6346 6345 -1
===========================================
+ Hits 45997 46043 +46
- Misses 24361 24364 +3
+ Partials 3612 3590 -22
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
reviewed
Nov 3, 2023
akhilnarang
force-pushed
the
restrictedpython-print
branch
from
5491294
to
dd1a275
Compare
ankush
reviewed
Nov 3, 2023
akhilnarang
force-pushed
the
restrictedpython-print
branch
4 times, most recently
from
918186c
to
84a6747
Compare
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
…tead of `log()` Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
akhilnarang
force-pushed
the
restrictedpython-print
branch
from
84a6747
to
4ab13ff
Compare
|
Current state works fine, just has this warning Comes from https://github.com/zopefoundation/RestrictedPython/blob/master/src/RestrictedPython/transformer.py#L478-L509 |
RestrictedPython warns us if we call `print()` don't use their `printed` variable Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
akhilnarang
force-pushed
the
restrictedpython-print
branch
from
5d1c6a2
to
5b0150e
Compare
ankush
force-pushed
the
restrictedpython-print
branch
from
63d6860
to
248919d
Compare
ankush
force-pushed
the
restrictedpython-print
branch
from
248919d
to
8b87147
Compare
ankush
approved these changes
Nov 20, 2023
This can be moved to level 2 when required
ankush
force-pushed
the
restrictedpython-print
branch
from
8b87147
to
7b11e28
Compare
ankush
added
do not backport
and removed
add-test-cases
ankush
added
backport version-15-hotfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #22582
print()can now be used withinsafe_exec()calls - server scripts, system console, etc.For system console, it shows normally in output
For server scripts, a new field has been added
Debug LogFor doc events and API, the printed values are part of debug log.
[no-docs]