Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore case of filetype #23146

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: ignore case of filetype #23146

merged 1 commit into from
Nov 8, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Nov 7, 2023 •
edited 

new frappe.ui.FileUploader({
	restrictions: {
		allowed_file_types: [".csv"],
	},
});

Before

  • test.csv ✅
  • test.CSV 🚫

After

  • test.csv ✅
  • test.CSV ✅

@barredterra barredterra requested review from a team and shariquerik and removed request for a team November 7, 2023 16:08
@ankush ankush merged commit 9d45ee8 into frappe:develop Nov 8, 2023
21 of 24 checks passed
This was referenced Nov 8, 2023
Merged
Merged
Merged
ankush added a commit that referenced this pull request Nov 8, 2023
@ankush
Merge pull request #23153 from frappe/mergify/bp/version-15-hotfix/pr…
da9acec 
…-23146

fix: ignore case of filetype (backport #23146)
@barredterra barredterra deleted the ignore-filetype-case branch November 8, 2023 09:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush ankush approved these changes

@shariquerik shariquerik Awaiting requested review from shariquerik

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barredterra @ankush