fix: incorrect date range when relinking files #23161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TMF42
requested review from
a team and
surajshetty3416
and removed request for
a team
github-actions
bot
added
the
add-test-cases
Codecov Report
@@ Coverage Diff @@
## develop #23161 +/- ##
===========================================
+ Coverage 61.61% 62.27% +0.66%
===========================================
Files 770 770
Lines 75270 73790 -1480
Branches 6361 6356 -5
===========================================
- Hits 46378 45956 -422
+ Misses 25271 24214 -1057
+ Partials 3621 3620 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
imo, no additional tests are needed. It does however fix 1 failing test from the original PR in cypress/integration/control_attach.js |
ankush
approved these changes
Nov 12, 2023
ankush
added
backport version-14-hotfix
This was referenced Nov 12, 2023
|
This was also incorrect on MariaDB, probably just worked because mariadb is bit more forgiving. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: #22693 introduced a method to relink files before saving documents. Done by @maharshivpatel
One of the timestamps, to query recent file uploads is passed along as datetime.deltatime to frappe.db.exists, which causes exceptions with postgres DBs.
psycopg2.errors.InvalidDatetimeFormat: invalid input syntax for type timestamp: "0:59:59.999966" LINE 1: ...ttached_to_field"='attach' AND "creation" BETWEEN '0:59:59.9...