fix: DocType Number Card #23171
Merged
fix: DocType Number Card #23171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field becomes read only in production, so after "Menu" > "Duplicate", it wasn't possible to disable "Is Standard " for the copy.
Disable form is a one way street and cannot adapt to changed conditions
barredterra
requested review from
a team and
shariquerik
and removed request for
a team
barredterra
added
backport version-14-hotfix
|
Failing cypress tests are unrelated |
shariquerik
approved these changes
Nov 18, 2023
This was referenced Nov 18, 2023
shariquerik
added a commit
that referenced
this pull request
Nov 18, 2023
…-23171 fix: DocType Number Card (backport #23171)
shariquerik
added a commit
that referenced
this pull request
Nov 18, 2023
…-23171 fix: DocType Number Card (backport #23171)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This was not possible, because standard Number Cards, especially ones of type "Custom", could not be duplicated and saved.
Solution
Don't copy value of "Is Standard" checkbox
The field becomes read only in production, so after "Menu" > "Duplicate", it wasn't possible to disable "Is Standard " for the copy.
Disable/enable only the save button, not the entire form
Disable form is a one way street and cannot adapt to changed conditions, e.g. changing value of "Is Standard" during duplication.
Move field descriptions to the doctype definition
Unrelated refactor