fix: rename doc old_doc bug and validate for rename field #23248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate
arg forrename_field()
since I had a use case where I didn't want the validation to be made. For example: in v14 erpnext, there's a doctype with a fieldname "A". In v15, that doctype was moved to a separate lending app after which the fieldname was renamed to "B". Now on v14->v15 migration, on installation of the lending app, I'm running a patch to rename fieldname "A" to "B", but inrename_field()
,frappe.db.has_column(doctype, old_fieldname)
would fail since the doctype won't have the old fieldname "A".rename_doc()
is called withvalidate
=False, anold_doc
is not defined error is thrown sinceold_doc
is initialised only ifvalidate
=True. So now that one line usingold_doc
is only executed ifvalidate
=True.