Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebForm): Fix Date, Float, Table, Phone controls #23262

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Nov 17, 2023

if ([frappe.ui.keyCode.BACKSPACE].includes(key_code)) {

var { TAB, UP: UP_ARROW, DOWN: DOWN_ARROW } = frappe.ui.keyCode;

const first_day_of_the_week = frappe.sys_defaults.first_day_of_the_week || "Sunday";

(frappe.boot && frappe.boot.sysdefaults && frappe.boot.sysdefaults.number_format) ||

@cogk cogk requested review from a team and shariquerik and removed request for a team November 17, 2023 15:24
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #23262 (f5f11a4) into develop (283e91f) will increase coverage by 0.12%.
Report is 33 commits behind head on develop.
The diff coverage is 10.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23262      +/-   ##
===========================================
+ Coverage    62.13%   62.25%   +0.12%     
===========================================
  Files          770      770              
  Lines        73938    73750     -188     
  Branches      6349     6346       -3     
===========================================
- Hits         45938    45912      -26     
+ Misses       24386    24226     -160     
+ Partials      3614     3612       -2     
Flag Coverage Δ
server 70.71% <10.34%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@shariquerik shariquerik added the backport version-15-hotfix Backport the PR to v15 label Nov 18, 2023
@shariquerik shariquerik merged commit 41a7d8b into frappe:develop Nov 18, 2023
23 of 26 checks passed
shariquerik added a commit that referenced this pull request Nov 18, 2023
…-23262

fix(WebForm): Fix Date, Float, Table, Phone controls (backport #23262)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants