Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase length for address lines #23308

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Nov 20, 2023

140 char default limit is often not enough as demonstrated here #23259

140 char default limit is often not enough as demonstrated here frappe#23259
@ankush ankush requested review from a team and surajshetty3416 and removed request for a team November 20, 2023 11:59
@ankush ankush added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #23308 (c6371cb) into develop (94b2e50) will increase coverage by 0.09%.
Report is 73 commits behind head on develop.
The diff coverage is 73.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23308      +/-   ##
===========================================
+ Coverage    62.18%   62.28%   +0.09%     
===========================================
  Files          770      771       +1     
  Lines        73970    73820     -150     
  Branches      6346     6343       -3     
===========================================
- Hits         45997    45976      -21     
+ Misses       24361    24235     -126     
+ Partials      3612     3609       -3     
Flag Coverage Δ
server 70.73% <73.10%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush disabled auto-merge November 20, 2023 15:31
@ankush ankush merged commit 3cd06d7 into frappe:develop Nov 20, 2023
22 of 26 checks passed
@ankush ankush deleted the addr_line branch November 20, 2023 15:31
ankush added a commit that referenced this pull request Nov 20, 2023
…-23308

fix: increase length for address lines (backport #23308)
ankush added a commit that referenced this pull request Nov 20, 2023
…-23308

fix: increase length for address lines (backport #23308)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant