fix(event/sync_communication): add distinct while querying communication links
#23322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation links There's cases where these are duplicated Signed-off-by: Akhil Narang <me@akhilnarang.dev>
akhilnarang
requested review from
a team,
shariquerik and
ankush
and removed request for
a team
github-actions
bot
added
the
add-test-cases
akhilnarang
added
backport version-14-hotfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #23322 +/- ##
========================================
Coverage 62.27% 62.27%
========================================
Files 771 771
Lines 73822 73821 -1
Branches 6342 6342
========================================
+ Hits 45974 45975 +1
+ Misses 24239 24237 -2
Partials 3609 3609
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
approved these changes
Nov 21, 2023
ankush
added a commit
that referenced
this pull request
Nov 21, 2023
…-23322 fix(event/sync_communication): add `distinct` while querying communication links (backport #23322)
ankush
added a commit
that referenced
this pull request
Nov 21, 2023
…-23322 fix(event/sync_communication): add `distinct` while querying communication links (backport #23322)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's cases where these are duplicated - have noticed it happening in power of 2.
The duplication needs to be investigated separately - it seems like deduplication is only being called for Email communication
https://github.com/frappe/frappe/blob/develop/frappe/core/doctype/communication/communication.py#L167-L170
Internal Reference: 5969