fix(web_form): check properties for title field as well #23342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
akhilnarang
requested review from
a team and
shariquerik
and removed request for
a team
github-actions
bot
added
the
add-test-cases
akhilnarang
added
backport version-14-hotfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #23342 +/- ##
===========================================
+ Coverage 62.24% 62.26% +0.01%
===========================================
Files 771 771
Lines 73891 74028 +137
Branches 6342 6344 +2
===========================================
+ Hits 45996 46096 +100
- Misses 24286 24342 +56
+ Partials 3609 3590 -19
Flags with carried forward coverage won't be shown. Click here to find out more. |
shariquerik
approved these changes
Nov 22, 2023
This was referenced Nov 22, 2023
akhilnarang
added a commit
that referenced
this pull request
Nov 22, 2023
…-23342 fix(web_form): check properties for title field as well (backport #23342)
akhilnarang
added a commit
that referenced
this pull request
Nov 22, 2023
…-23342 fix(web_form): check properties for title field as well (backport #23342)
ankush
reviewed
Nov 22, 2023
| @@ -692,6 +692,13 @@ def get_link_options(web_form_name, doctype, allow_read_on_all_link_options=Fals | |||
| if value and int(value) == 1: | |||
| show_title_field_in_link = True | |||
|
|
|||
| if not title_field: | |||
There was a problem hiding this comment.
@akhilnarang this is needlessly complicated!
Just use frappe.get_meta(doctype) which is mix of doctype + property setter.
There was a problem hiding this comment.
Thanks, will open a PR to simplify
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, setting the
show_title_field_in_linkon sites without developer mode on seems useless, as it doesn't change anything