Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scoped progress bar on bulk submit/cancel #23623

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Dec 5, 2023

Before

On bulk-submit or bulk-cancel, the progress bar was shown on all open tabs.

After

The progress bar shows only on the current tab.

Other changes:

  • Better variable names
  • Improve translatability of error message
  • Small refactors

@barredterra barredterra requested review from a team and surajshetty3416 and removed request for a team December 5, 2023 18:39
@barredterra barredterra changed the title bulk submit cancel feat: scoped progress bar on bulk submit/cancel Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #23623 (68c0e6f) into develop (811d167) will decrease coverage by 0.01%.
Report is 4 commits behind head on develop.
The diff coverage is 81.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23623      +/-   ##
===========================================
- Coverage    62.18%   62.17%   -0.01%     
===========================================
  Files          774      774              
  Lines        74178    74151      -27     
  Branches      6393     6390       -3     
===========================================
- Hits         46124    46102      -22     
+ Misses       24386    24384       -2     
+ Partials      3668     3665       -3     
Flag Coverage Δ
server 71.08% <81.25%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush
Copy link
Member

ankush commented Dec 6, 2023

@akhilnarang related to that other FR you're working on

@ankush ankush merged commit bbeeebb into frappe:develop Dec 6, 2023
21 of 25 checks passed
@barredterra barredterra deleted the bulk-submit-cancel branch December 6, 2023 14:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
@ankush ankush added the backport version-15-hotfix Backport the PR to v15 label Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants