fix(text_editor): Fix bubble's link tooltip clipping #23911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cogk
changed the title
cogk
force-pushed
the
fix-text-editor-tooltip
branch
from
14b32cb
to
11de8cd
Compare
cogk
force-pushed
the
fix-text-editor-tooltip
branch
from
11de8cd
to
5019e78
Compare
|
unrelated CI test failing if I'm not mistaken, but I would love a manual review if possible |
ankush
added
the
defer backport
ankush
reviewed
Dec 28, 2023
| @@ -208,7 +208,7 @@ frappe.ui.form.ControlTextEditor = class ControlTextEditor extends frappe.ui.for | |||
| }, | |||
| theme: this.df.theme || "snow", | |||
| readOnly: this.disabled, | |||
| bounds: this.quill_container[0], | |||
| bounds: document.body, | |||
There was a problem hiding this comment.
This causes quill to overflow everywhere. The actual content also 😔
There was a problem hiding this comment.
Argh sorry, I should've tested more! 😄
ankush
added a commit
that referenced
this pull request
Dec 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23903 using info from quilljs/quill#360 (comment) and quilljs/quill#360 (comment)