Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong operator in version check #24898

Merged
merged 4 commits into from
Feb 15, 2024
Merged

fix: wrong operator in version check #24898

merged 4 commits into from
Feb 15, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Feb 15, 2024 •
edited

  • fix wrong operator in version check
  • use a better variable name (is_downgrade)
  • extract get_backup_version into a separate method

@barredterra barredterra requested a review from a team as a code owner February 15, 2024 10:31
@barredterra barredterra requested review from surajshetty3416 and removed request for a team February 15, 2024 10:31
@barredterra barredterra changed the title fix version check fix: wrong operator in version check Feb 15, 2024
@barredterra barredterra merged commit e812143 into frappe:develop Feb 15, 2024
23 checks passed
@barredterra barredterra deleted the fix-version-check branch February 15, 2024 11:16
@barredterra
Copy link
Collaborator Author

Backport not needed at the moment (v15 is not affected)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akhilnarang akhilnarang akhilnarang left review comments

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416 surajshetty3416 is a code owner automatically assigned from frappe/frappe-review-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barredterra @akhilnarang