Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: user facing task queues #25138

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

feat: user facing task queues #25138

wants to merge 18 commits into from

Commits on Jun 27, 2024

  1. feat: add in a method to convert a callable to the equivalent string 

    Basically a combination of callable.__module__ + . + callable.__qualname__

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    91be615 View commit details
    Browse the repository at this point in the history

  2. feat: add in a function to create a notification log entry 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    c90abb2 View commit details
    Browse the repository at this point in the history

  3. feat: add in Background Task doctype 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    8d249d8 View commit details
    Browse the repository at this point in the history

  4. feat: add in an API endpoint to enqueue a task, and stop a task 

    Make use of `rq.Job`'s `meta` field instead of relying on
`kwargs` -> `Job._kwargs` - doesn't seem to be reliable when a job is
killed

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    8d8a223 View commit details
    Browse the repository at this point in the history

  5. feat: add in a button to stop a task 

    Cleanup some code
Set status to started when starting

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    96a6b22 View commit details
    Browse the repository at this point in the history

  6. feat: check that the method exists before trying to enqueue 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1cae138 View commit details
    Browse the repository at this point in the history

  7. chore: set task ID in frappe.job 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    edba303 View commit details
    Browse the repository at this point in the history

  8. feat: show status in list 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    15602e2 View commit details
    Browse the repository at this point in the history

  9. feat: basic task progress in doc view 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    deca667 View commit details
    Browse the repository at this point in the history

  10. feat: allow retrying 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5836e7d View commit details
    Browse the repository at this point in the history

  11. fix: add in a fallback to callbacks 

    Ensure that the status is set even if an exception occurs

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    29b8691 View commit details
    Browse the repository at this point in the history

  12. chore: drop event, add original_task field 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    fcdbed0 View commit details
    Browse the repository at this point in the history

  13. fix(request): handle HTTP 201 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d1ffec1 View commit details
    Browse the repository at this point in the history

  14. feat: improve retry task 

    Display a dialog, allow users to customize the values before retrying

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b468e3c View commit details
    Browse the repository at this point in the history

  15. fix: don't publish task progress to all users 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6356c2f View commit details
    Browse the repository at this point in the history

  16. feat: show task runtime 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    420d27b View commit details
    Browse the repository at this point in the history

  17. chore: mark as beta; update sort order to match other doctypes 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e469256 View commit details
    Browse the repository at this point in the history

  18. refactor: some changes based on review 

    Signed-off-by: Akhil Narang <me@akhilnarang.dev>
    @akhilnarang
    akhilnarang committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    25e7278 View commit details
    Browse the repository at this point in the history