Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workspace): Allow user to choose a default workspace #25257

Merged
merged 3 commits into from Mar 20, 2024
Merged

feat(workspace): Allow user to choose a default workspace #25257

merged 3 commits into from Mar 20, 2024

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Mar 6, 2024 •
edited

@cogk cogk requested a review from a team as a code owner March 6, 2024 10:16
@cogk cogk requested review from ankush and removed request for a team March 6, 2024 10:16
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Mar 6, 2024
@cogk
Copy link
Contributor Author

cogk commented Mar 6, 2024

cc @NagariaHussain @shariquerik

shariquerik
shariquerik requested changes Mar 11, 2024
View reviewed changes
frappe/core/doctype/user/user.js Outdated Show resolved Hide resolved
shariquerik
shariquerik requested changes Mar 11, 2024
View reviewed changes
frappe/core/doctype/user/user.json Outdated Show resolved Hide resolved
@ankush ankush added the backport version-15-hotfix Backport the PR to v15 label Mar 15, 2024
cogk and others added 2 commits March 19, 2024 16:24
@cogk @shariquerik
fix(workspace): Don't allow Welcome as default workspace
e3d00e9 
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
@shariquerik
chore: moved workspaces section inside settings tab
61cac70
@shariquerik shariquerik merged commit d7dbf77 into frappe:develop Mar 20, 2024
24 checks passed
@mergify mergify bot mentioned this pull request Mar 20, 2024
Merged
@cogk
Copy link
Contributor Author

cogk commented Mar 20, 2024

@shariquerik 👍 I believe there is a problem with the filtering of the awesomplete, based on the roles of the User.

In the Awesomplete I see more workspaces than I could access, which means that I can select a default workspace that I can't access. I think this is related to the permission model of the Workspaces.

frappe.get_list("Workspace") returns all the Workspaces of the system, which means the awesomplete does too, even if I don't have access to them. It's not really a problem though, just a small footgun to avoid.

image

@cogk
Copy link
Contributor Author

cogk commented Mar 20, 2024

Docs updated 👍

Just a small paragraph here: https://frappeframework.com/docs/user/en/desk/workspace/access#default-workspace

shariquerik added a commit that referenced this pull request Mar 21, 2024
@shariquerik
Merge pull request #25564 from frappe/mergify/bp/version-15-hotfix/pr…
d4de8f7 
…-25257

feat(workspace): Allow user to choose a default workspace (backport #25257)
@kehwar kehwar mentioned this pull request Mar 27, 2024
Closed
@cogk cogk mentioned this pull request Mar 28, 2024
Merged
@mergify mergify bot mentioned this pull request Mar 29, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shariquerik shariquerik shariquerik approved these changes

@ankush ankush Awaiting requested review from ankush ankush was automatically assigned from frappe/frappe-review-team

Assignees

@shariquerik shariquerik

Labels
add-test-cases Add test case to validate fix or enhancement backport version-15-hotfix Backport the PR to v15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Home / Workspace per user
3 participants
@cogk @shariquerik @ankush