Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add is_virtual in bootstrap schema #25296

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Mar 10, 2024

This is what's actually causing test to fail. Recorder is getting marked as non-virtual doctype hence get_list doesn't work and tests fail.

image

@ankush ankush requested review from a team and akhilnarang and removed request for a team March 10, 2024 06:50
@ankush ankush enabled auto-merge March 10, 2024 06:52
@ankush ankush added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels Mar 10, 2024
@ankush ankush merged commit a103335 into frappe:develop Mar 10, 2024
19 of 24 checks passed
@ankush ankush deleted the is_virtual_snafu branch March 10, 2024 07:17
ankush added a commit that referenced this pull request Mar 10, 2024
…-25296

fix: Add `is_virtual` in bootstrap schema (backport #25296)
ankush added a commit that referenced this pull request Mar 10, 2024
…-25296

fix: Add `is_virtual` in bootstrap schema (backport #25296)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant