Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: In-Context Translation #25677

Merged
merged 2 commits into from Mar 27, 2024
Merged

feat: In-Context Translation #25677

merged 2 commits into from Mar 27, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Mar 27, 2024 •
edited

  • Add a new language called "In-Context Translation" (disabled by default)
  • Add a file that translates source strings to Crowdin identifiers
  • If this language is enabled and active for the current user, load a Crowdin script that replaces the identifiers with the existing translations stored on Crowdin and enables the translation of missing strings.

Bildschirmfoto 2024-03-27 um 12 49 35

Bildschirmfoto 2024-03-27 um 12 45 11

Related Crowdin config https://crowdin.com/project/frappe/tools/in-context

@barredterra barredterra requested a review from a team as a code owner March 27, 2024 11:53
@barredterra barredterra requested review from ankush and removed request for a team March 27, 2024 11:53
ankush
ankush reviewed Mar 27, 2024
View reviewed changes
frappe/www/app.html Outdated Show resolved Hide resolved
@barredterra
Copy link
Collaborator Author

barredterra commented Mar 27, 2024 •
edited

The top right action buttons are messed up because the translated strings get ripped apart by the shortcut manager

@ankush ankush merged commit 83eadd7 into frappe:develop Mar 27, 2024
21 of 24 checks passed
@barredterra barredterra deleted the in-context-translation branch March 27, 2024 15:55
This was referenced Mar 27, 2024
Merged
Merged
@barredterra barredterra mentioned this pull request Apr 8, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush ankush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barredterra @ankush