Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new payment processing hooks #25952

Closed
wants to merge 1 commit into from

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Apr 15, 2024

Context

frappe/payments#53 implements a new version of payment controllers which are more suitable for webshop checkouts and have a better frontend user flow.

The new version comes with a well-defined assortment of ref doc hooks for post-processing a payment flow within the business logic.

Proposal

  • This PR adds the new post-processing hooks
  • It also marks the previous ones as "Legacy Gateway"

no-docs

@blaggacao blaggacao requested a review from a team as a code owner April 15, 2024 12:15
@blaggacao blaggacao requested review from ankush and removed request for a team April 15, 2024 12:15
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Apr 15, 2024
Copy link

stale bot commented May 2, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added inactive and removed inactive labels May 2, 2024
@blaggacao blaggacao force-pushed the feat/new-payment-hooks branch 4 times, most recently from 07ab9b6 to bf5a602 Compare May 8, 2024 11:07
Copy link

stale bot commented May 24, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label May 24, 2024
@blaggacao
Copy link
Contributor Author

Please exempt from closing.

@blaggacao
Copy link
Contributor Author

@ankush can you excempt this from the bot, please?

@stale stale bot closed this Jun 5, 2024
@blaggacao
Copy link
Contributor Author

Why is the stalebot not respecting comments to understand that this is still rightfully pending? @ankush or @akhilnarang could you please do something about this issue, it's increasingly annoying and an absolutly horrible contributor experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-test-cases Add test case to validate fix or enhancement inactive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant