Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make report results ltr to work with SlickGrid #2603

Merged
merged 2 commits into from Apr 6, 2017
Merged

make report results ltr to work with SlickGrid #2603

merged 2 commits into from Apr 6, 2017

Conversation

dalwadani
Copy link
Contributor

Since no clear answer were given in the forums, I am not sure when (or if) another grid system will be implemented.
I think we should exclude the report results of the RTL support.

Copy link
Contributor

@netchampfaris netchampfaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen goes blank when scrolling. Please rebase and test it again.

@dalwadani
Copy link
Contributor Author

@netchampfaris I was not able to replicate your issue.
Could you provide more details?

@mhbu50
Copy link
Contributor

mhbu50 commented Apr 1, 2017

I just update to v8 and face these problems :

  • Column header is missing
  • The order of Column should be the opposite
  • alignment of filter button

image

https://discuss.erpnext.com/t/bug-in-report-page-rtl/22018

@netchampfaris
Copy link
Contributor

@dalwadani I think SlickGrid doesn't work well with ltr.
image

Also, I'm still facing the scrolling problem.

@dalwadani
Copy link
Contributor Author

@netchampfaris @mhbu50,
I think merging this commit will fix this issue as it did for my local server.

Copy link
Contributor

@netchampfaris netchampfaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one fixes it. Good to go!

@rmehta rmehta merged commit 1d24ea7 into frappe:develop Apr 6, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants