Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CSV export): allow custom decimal separator #26163

Merged
merged 1 commit into from Apr 25, 2024
Merged

feat(CSV export): allow custom decimal separator #26163

merged 1 commit into from Apr 25, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Apr 25, 2024 •
edited

In Europe, some software expects the comma character as decimal separator, in line with the prevailing number format.

Bildschirmfoto 2024-04-25 um 12 28 35

no-docs

@barredterra barredterra requested a review from a team as a code owner April 25, 2024 10:24
@barredterra barredterra requested review from akhilnarang and removed request for a team April 25, 2024 10:24
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Apr 25, 2024
@akhilnarang akhilnarang merged commit e455b7b into frappe:develop Apr 25, 2024
24 of 25 checks passed
@barredterra barredterra deleted the csv-decimal-sep branch April 25, 2024 13:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akhilnarang akhilnarang Awaiting requested review from akhilnarang akhilnarang was automatically assigned from frappe/frappe-review-team

Assignees
No one assigned
Labels
add-test-cases Add test case to validate fix or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barredterra @akhilnarang