Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restoring site breaks when checking backup version #26186

Merged
merged 4 commits into from
Apr 29, 2024
Merged

fix: restoring site breaks when checking backup version #26186

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce48a04
fix: restoring site breaks when checking backup version
king-phyte Apr 28, 2024
bcdf46c
fix: restoring site breaks when checking backup version
king-phyte Apr 29, 2024
d16379d
fix: version check when restoring site should be done from `match` scope
king-phyte Apr 29, 2024
6ea19e4
chore: add a `return None` for better readability
akhilnarang Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion frappe/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ def get_old_backup_version(sql_file_path: str) -> Version | None:
if match := re.search(r"Frappe (\d+\.\d+\.\d+)", header[0]):
backup_version = match[1]
king-phyte marked this conversation as resolved.
Show resolved Hide resolved

return Version(backup_version) if backup_version else None
return Version(backup_version) if match else None
king-phyte marked this conversation as resolved.
Show resolved Hide resolved


def get_backup_version(sql_file_path: str) -> Version | None:
Expand Down