Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Reuse cached user for get_user_lang #26350

Merged
merged 1 commit into from
May 7, 2024
Merged

perf: Reuse cached user for get_user_lang #26350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions frappe/translate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,20 +97,14 @@ def get_parent_language(lang: str) -> str:
def get_user_lang(user: str | None = None) -> str:
"""Set frappe.local.lang from user preferences on session beginning or resumption"""
user = user or frappe.session.user
lang = frappe.cache.hget("lang", user)

if not lang:
# User.language => Session Defaults => frappe.local.lang => 'en'
lang = (
frappe.db.get_value("User", user, "language")
or frappe.db.get_default("lang")
or frappe.local.lang
or "en"
)

frappe.cache.hset("lang", user, lang)

return lang
# User.language => Session Defaults => frappe.local.lang => 'en'
return (
frappe.get_cached_value("User", user, "language")
or frappe.db.get_default("lang")
or frappe.local.lang
or "en"
ankush marked this conversation as resolved.
Show resolved Hide resolved
)


def get_lang_code(lang: str) -> str | None:
Expand Down