Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve checked items after a search #26434

Merged
merged 1 commit into from
May 15, 2024

Conversation

akhilnarang
Copy link
Member

@akhilnarang akhilnarang commented May 14, 2024

MultiSelectDialog didn't preserve the checked fields after searching for something.
Store it separately in a set that can be restored.

Support ticket: 14167

@akhilnarang akhilnarang added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels May 14, 2024
@akhilnarang akhilnarang marked this pull request as ready for review May 15, 2024 06:10
@akhilnarang akhilnarang requested review from a team and ankush and removed request for a team May 15, 2024 06:10
@akhilnarang akhilnarang marked this pull request as draft May 15, 2024 06:25
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@akhilnarang akhilnarang marked this pull request as ready for review May 15, 2024 07:28
@akhilnarang akhilnarang merged commit 4298fc0 into frappe:develop May 15, 2024
24 checks passed
@akhilnarang akhilnarang deleted the fix-multiselectdialog branch May 15, 2024 07:42
akhilnarang added a commit that referenced this pull request May 15, 2024
…-26434

fix: preserve checked items after a search (backport #26434)
akhilnarang added a commit that referenced this pull request May 15, 2024
…-26434

fix: preserve checked items after a search (backport #26434)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant