Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): Stack modals when minimized #26458

Merged
merged 2 commits into from
May 17, 2024

Conversation

cogk
Copy link
Contributor

@cogk cogk commented May 16, 2024

Works for any number of modals, allows easy access to the last 5 modals. Over-engineered a little bit. Doesn't work well with long titles. https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child#the_of_selector_syntax

Test with:

new frappe.ui.Dialog({ title: "Lorem ipsum dolor sit amet", minimizable: true }).show()

@ankush ankush merged commit 17a0c9a into frappe:develop May 17, 2024
25 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants