Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade photoswipe and remove vendoring #26487

Merged
merged 6 commits into from
May 21, 2024

Conversation

rutwikhdev
Copy link
Contributor

@rutwikhdev rutwikhdev commented May 20, 2024

This lib barely worked since in v14. It's still broken! I highly doubt anybody uses this view as much. Removed a lot of code and functionality from the gallery view and kept only the basic essentials to browse images.

no-docs

@rutwikhdev rutwikhdev linked an issue May 20, 2024 that may be closed by this pull request
@rutwikhdev rutwikhdev marked this pull request as ready for review May 20, 2024 13:35
@ankush ankush merged commit 2953c16 into frappe:develop May 21, 2024
24 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade photoswipe and remove vendoring
2 participants