fix!: map columns correctly in query report via fieldnames

[phot0n]

This pr helps in mapping the report columns correctly as defined in the column table for query report type. Previously it used to map the columns in the sequence they're defined ..not corresponding with the fieldnames

before:

Screencast.2024-05-23.02.00.03.mp4

after:

Screencast.2024-05-23.01.58.27.mp4

This could be considered a breaking change if people have written queries without providing appropriate fieldnames in the column table.

[ankush]

ummm, isn't this different?

[ankush]

list[list[Any]] -> [list[dict[str, Any]]]

[phot0n]

that's the point 😆 - will update the description in a bit

[phot0n]

the code automatically handles it down the line btw:

frappe/frappe/desk/query_report.py

Lines 127 to 134 in c973d08

	if result and isinstance(result[0], list | tuple):
	for row in result:
	row_obj = {}
	for idx, column_name in enumerate(column_names):
	row_obj[column_name] = row[idx]
	data.append(row_obj)
	else:
	data = result

[phot0n]

tested this with aliased columns as well as with stuff like po.name - seems to work fine

Screencast.2024-05-23.02.35.01.mp4

[phot0n]

side note(s):

• the filter table should have the "mandatory" field checked by default (maybe only on query report type) as when people use %(x)s notation in their queries they waste their time in figuring out why even the simple stuff doesn't work.

• not sure why we need reference doctype and reference report field(s) shown for query report type?

• show all fields in the columns table in the grid view so that people don't have to "discover" them by clicking on edit

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.