feat: set the only email address as primary #26758
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some features rely on the Contact having the primary email set. If the Contact has only one email address, we can mark it as primary automatically. Only if there are more than one addresses available, the user has to choose which one should be set as primary.
barredterra
added
backport version-14-hotfix
github-actions
bot
added
the
add-test-cases
barredterra
removed
the
add-test-cases
|
@barredterra there are two email IDs as shown in the video sample, and the user removes the tick as shown, leaving no primary email address, should we then make one of the emails primary? What is the use case? |
|
@rehanrehman389 If many emails are available and none is marked as primary, they are treated as equals and neither is automatically set as the primary. I did not change this part of the code. Only when there is exactly one email address in the table, we can be certain that it must be the primary and automatically enable the checkbox for the user. |
This was referenced Jun 14, 2024
barredterra
added a commit
that referenced
this pull request
Jun 15, 2024
…-26758 feat: set the only email address as primary (backport #26758)
barredterra
added a commit
that referenced
this pull request
Jun 15, 2024
…-26758 feat: set the only email address as primary (backport #26758)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some features rely on the Contact having the primary email set. If the Contact has only one email address, we can mark it as primary automatically. Only if there are more than one addresses available, the user has to choose which one should be set as primary.
primary_email.mov
Internal ref: MRC-140