Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Client Rewrite): List View #26807

Merged
merged 57 commits into from
Jul 1, 2024
Merged

feat(Client Rewrite): List View #26807

merged 57 commits into from
Jul 1, 2024

Conversation

GursheenK
Copy link
Member

@GursheenK GursheenK commented Jun 20, 2024 •
edited
Loading

Added List View for Desk.

List Controls
Screen.Recording.2024-06-20.at.6.16.51.PM.mov
List Column Settings
Screen.Recording.2024-06-20.at.6.05.14.PM.mov
Default & Saved Views
Screen.Recording.2024-06-20.at.6.39.19.PM.mov

Default View

  • In the default list view, DocFields which have the in_list_view check enabled are shown initially.
  • Any column changes like resizing, change of column sequence and change of labels are saved to the default view automatically.
  • Any sort selector changes like change of sort order or the sort field are also stored automatically.
  • On clicking the Reset to Default button, the customisations on top of the default view are erased.

Saved / Custom Views

  • One can optionally save a particular configuration of columns, filters and sorting as a named view to quickly navigate to it. These views are shown inside the View Switcher dropdown as saved views.
  • Any changes made to the Saved Views are not automatically saved until the user explicitly clicks on the Save Changes button inside the View Switcher dropdown.

no-docs

GursheenK and others added 30 commits May 17, 2024 18:26
@GursheenK
feat: show list from stored config
b6ad400
@GursheenK
feat: list control component for columns
f35c75e
@GursheenK
feat: update column details
c623215
@GursheenK
chore: upgrade feather-icons for default view icons
11d8165
@GursheenK
feat: add view switcher dropdown
f4d3e4f
@GursheenK
refactor: resource for fetching config
9b70665
@GursheenK
feat: store filters for config
1ff82f4
@GursheenK
feat: add ListFilter component
4431073
@GursheenK
feat: handle filters using route params
d11480e
@GursheenK
refactor: cleanup event emitting for filters
cc2c453
@GursheenK
refactor: watcher for column picker
2b6a55f
@GursheenK
feat: multiple filtering for single field
f7dc424
@GursheenK
refactor: change dropdown button for saving changes
01b1ee7
@GursheenK
feat: add view actions modal
5362aab
@GursheenK
feat: list sort selector
f01bd5f
@GursheenK
refactor: separate out view actions modal
9bd8ada
@GursheenK
feat: load filters from query params
c564350
@GursheenK @ruchamahabal
chore: auto format code using prettier
176489d 
Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK @ruchamahabal
chore: ignore formatting changes in blame
8e835b8 
Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK @ruchamahabal
refactor: move ListView code to the correct page
5910867 
Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK @ruchamahabal
refactor: group ListView components
e3bf522 
Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK @ruchamahabal
refactor: list controls
20469dc 
- Move ViewSwitcher to LHS

- Fix ordering of List Controls

- Fix Sort Order Control width

Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK @ruchamahabal
fix: filter popover padding
7278867 
- sort order tooltip

Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK
refactor: fix naming for view actions
17fe47c
@GursheenK
feat: format cells based on fieldtype
fa675ca
@GursheenK
feat: save overriden default config
77b2e14
@GursheenK
feat: auto-save overriden default config
af83dcd
@GursheenK
refactor: remove redundant code from list controls
1b8a004
@GursheenK
refactor: seperate fetch and rerender events
22e7d9c
@GursheenK
refactor: cleanup filter fieldtype constants
09f7de1
GursheenK and others added 16 commits June 17, 2024 12:39
@GursheenK @ruchamahabal
fix: use predefined Link control in filters
0ff4ef2 
Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK @ruchamahabal
chore: upgrade frappe-ui
5554cbe 
Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK @ruchamahabal
refactor: replace Date controls with frappe-ui controls
f1cad00 
Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK @ruchamahabal
refactor: cleanup view switcher and filter constants
e26a469 
Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK @ruchamahabal
refactor: cleanup list formatters
0fe6ad7 
Co-authored-by: Rucha Mahabal <24353136+ruchamahabal@users.noreply.github.com>
@GursheenK
refactor: cleanup filter operators
419993a
@GursheenK
fix: show string value for equals operator in query
ec117df
@GursheenK
fix: case for when previously set filter operator is equals
7bdef80
@GursheenK
fix: use string for link control options
5dbb073
@GursheenK
fix: fixed width for sidebar and router view
bb0e270
@GursheenK
refactor: separate utility for query filters
5fefeea
@GursheenK
chore: register FeatherIcon component globally
8104d0c
@GursheenK
fix: use readable view slug in route
1edd28b
@GursheenK
refactor: filter select option and object util
dcb77c2
@GursheenK
chore: resolve linter
163e934
@ruchamahabal
chore: Merge branch 'client-rewrite' into listview
d600b41
ruchamahabal
ruchamahabal requested changes Jun 23, 2024
View reviewed changes
frappe/desk/doctype/view_config/view_config.json Show resolved Hide resolved
desk/src/utils/list.js Outdated Show resolved Hide resolved
desk/src/utils/list.js Outdated Show resolved Hide resolved
desk/src/utils/list.js Show resolved Hide resolved
desk/src/components/List/ListFilters.vue Show resolved Hide resolved
frappe/desk/doctype/view_config/view_config.py Outdated Show resolved Hide resolved
frappe/desk/doctype/view_config/view_config.py Outdated Show resolved Hide resolved
frappe/desk/doctype/view_config/view_config.py Outdated Show resolved Hide resolved
frappe/desk/doctype/view_config/view_config.py Outdated Show resolved Hide resolved
desk/src/components/List/ListFilters.vue Outdated Show resolved Hide resolved
@ruchamahabal ruchamahabal marked this pull request as ready for review July 1, 2024 08:32
@ruchamahabal ruchamahabal merged commit 4e7bb75 into frappe:client-rewrite Jul 1, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GursheenK @ruchamahabal