Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: whitelisted method for custom alert trigger from safe exec #26821

Closed
wants to merge 1 commit into from
Closed

fix: whitelisted method for custom alert trigger from safe exec #26821

wants to merge 1 commit into from

Conversation

blaggacao
Copy link
Contributor

Context

  • Server script: frappe.enqueue("frappe.email.doctype.notification.notification.trigger_notification", enqueue_after_commit=True, doc=doc, alert="My Custom Notification")
  • Currently not possible
  • doc.queue_action("run_notifications", enqueue_after_commit=True, method="Custom")` is not an alternative as it doesn't allow to control for sequence

@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Jun 21, 2024
@blaggacao
Copy link
Contributor Author

ping

1 similar comment
@blaggacao
Copy link
Contributor Author

ping

@blaggacao
Copy link
Contributor Author

This doesn't actually work.

@blaggacao blaggacao closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
add-test-cases Add test case to validate fix or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@blaggacao