Enhance multi file upload #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
netchampfaris
commented
Mar 22, 2017
•
netchampfaris
commented
|
👍 Nice! Maybe each file button should be on a new line (block), it would be better alignment / consistency. Also maybe the lock can be just normal instead of gold (?) |
rmehta
requested changes
Mar 23, 2017
frappe/public/js/frappe/upload.js
Outdated
| }); | ||
| }, | ||
| make_file_pill: function(filename, show_private) { | ||
| var $file = $(` | ||
| <div class="btn-group" role="group" data-filename="${filename}"> |
|
Very nice usability help ;-) |
netchampfaris
force-pushed
the
multiple-file-upload
branch
from
6e62a1d
to
3dd44b3
Compare
|
Changed to table view
|
|
Very nice. I like the way that you pay attention to the aesthetics as well as the functionality |
You can now upload files programmatically like
```
frappe.upload.make({
...
files: fileobj_array,
...
})
```
No need to use `multifile_upload` method.
Multiple file upload is enabled by default on all Attach dialogs.
netchampfaris
force-pushed
the
multiple-file-upload
branch
from
3dd44b3
to
9237187
Compare
|
|
|
did you remove the "is" in "is private" ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.