New Contacts Module and Salutation and Gender in Contact #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmehta
requested changes
Apr 13, 2017
| update_gender_and_salutation() | ||
|
|
||
| def update_gender_and_salutation(): | ||
| default_genders = ["Male", "Female", "Other"] |
|
|
||
| default_genders = ["Male", "Female", "Other"] | ||
|
|
||
| default_salutations = ["Dr.", "Mr.", "Ms.", "Mx.", "Sir", "Dame", "Esq.", "Lady", "Lord", "Mrs.", "Sire", "Madam", "Miss.", "Master", "Proff.", "Captain", "Mistress", "Gentleman", "President", "Principal"] |
There was a problem hiding this comment.
Lets not add the period . also Professor is Prof not Proff... Mistress ?? 😜
Lets only keep the common ones
KanchanChauhan
force-pushed
the
salutation-in-contact
branch
3 times, most recently
from
ed06c3c
to
3fa2615
Compare
2 tasks
rmehta
requested changes
Apr 17, 2017
| update_gender_and_salutation() | ||
|
|
||
| def update_gender_and_salutation(): | ||
| records = get_genders_and_salutations() |
There was a problem hiding this comment.
get_genders_and_salutations() and add_genders_and_salutations(record) can be the same function!
There was a problem hiding this comment.
for better readability and clarity :P
There was a problem hiding this comment.
KanchanChauhan
force-pushed
the
salutation-in-contact
branch
2 times, most recently
from
6aa2243
to
eaea35c
Compare
rmehta
requested changes
Apr 18, 2017
| records = [{'doctype': 'Gender', 'gender': d} for d in default_genders] | ||
| records += [{'doctype': 'Salutation', 'salutation': d} for d in default_salutations] | ||
| for record in records: | ||
| doc_name = record.get("doctype") |
There was a problem hiding this comment.
Tested and removed the if exist code, not required since we are checking DuplicateEntryError
KanchanChauhan
force-pushed
the
salutation-in-contact
branch
from
f63580d
to
6e4138e
Compare
KanchanChauhan
force-pushed
the
salutation-in-contact
branch
3 times, most recently
from
1d5023d
to
6f34582
Compare
KanchanChauhan
force-pushed
the
salutation-in-contact
branch
from
6f34582
to
915c40d
Compare
rmehta
approved these changes
Jun 13, 2017
nabinhait
added a commit
that referenced
this pull request
Jun 14, 2017
This reverts commit f52e389.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also merge frappe/erpnext#9199