-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiselect dialog for getting items #3255
Conversation
date still missing? |
Updated |
Moved test to erpnext |
still don't see dates in the selection dialog??? |
${ | ||
head ? __(frappe.model.unscrub(column)) | ||
|
||
: (column !== "name" ? __(result[column]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be formatted frappe.format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just set value outside of the template for better readability
${ | ||
head ? __(frappe.model.unscrub(column)) | ||
|
||
: (column !== "name" ? __(result[column]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just set value outside of the template for better readability
Hello @pratu16x7 , i finally tested multiselect. I had been create around 100 invoices with this feature. Everything works great. I will suggest one more correction when you find time for that. I found dificult when i have to search several DN. It will be useful to search DN, mark it and select another, and to have 2 selected DN, and still have options to search. Another solution is to create a button ''add'' in the form to insert DN to SI, and form for multiselect stay opened. |
Any update for this? When I select item, and then search another item, my previous selected item are gone. |
With: frappe/erpnext#8583
Mapping to and from the form (With oldest selected by default):
Quantities of duplicate items are not combined by default, given that they can have different rates.
Make new placeholder:
The dialog filter link fields require to be given as 'setters' (similar to filters; they are used for initial filtering as well) in the map_current_doc arguments:
The setters for all the relevant forms are set in commit frappe/erpnext@fc4cf21