Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect dialog for getting items #3255

Merged
merged 15 commits into from
May 15, 2017
Merged

Multiselect dialog for getting items #3255

merged 15 commits into from
May 15, 2017

Conversation

pratu16x7
Copy link
Contributor

@pratu16x7 pratu16x7 commented May 10, 2017

With: frappe/erpnext#8583

Mapping to and from the form (With oldest selected by default):

multiselect

Quantities of duplicate items are not combined by default, given that they can have different rates.

Make new placeholder:

make_new 6 39 14 pm

The dialog filter link fields require to be given as 'setters' (similar to filters; they are used for initial filtering as well) in the map_current_doc arguments:

screen shot 2017-04-26 at 12 37 55 pm

The setters for all the relevant forms are set in commit frappe/erpnext@fc4cf21

@pratu16x7
Copy link
Contributor Author

Updates:

  • Add date by default in the list view (its most important)

  • Check the oldest matching Quotation (or linked document) by default. In most cases, there will be only one related document, so you can save the click.

  • Test case for map_docs

  • The .js and .py scrub functions can be improved for things like BOM, but apparently abbreviations(BOM, POS) are exceptional cases that could be blacklisted()

  • Quotations don't allow for adding items once the table is non-empty (hence, no successive adding).
    screen shot 2017-05-10 at 1 33 21 pm
    Perhaps multiselect isn't applicable here.

@rmehta
Copy link
Member

rmehta commented May 10, 2017

date still missing?

@pratu16x7
Copy link
Contributor Author

Updated

@pratu16x7
Copy link
Contributor Author

Moved test to erpnext

@rmehta
Copy link
Member

rmehta commented May 11, 2017

still don't see dates in the selection dialog???

${
head ? __(frappe.model.unscrub(column))

: (column !== "name" ? __(result[column])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be formatted frappe.format

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just set value outside of the template for better readability

${
head ? __(frappe.model.unscrub(column))

: (column !== "name" ? __(result[column])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just set value outside of the template for better readability

@pratu16x7
Copy link
Contributor Author

Formatted dates

screen shot 2017-05-11 at 3 55 12 pm

@rmehta rmehta merged commit b23aa14 into frappe:develop May 15, 2017
@vladucoju
Copy link

Hello @pratu16x7 , i finally tested multiselect. I had been create around 100 invoices with this feature. Everything works great. I will suggest one more correction when you find time for that. I found dificult when i have to search several DN. It will be useful to search DN, mark it and select another, and to have 2 selected DN, and still have options to search. Another solution is to create a button ''add'' in the form to insert DN to SI, and form for multiselect stay opened.
Without this you did a great job. This directly produce impact on productivity and Accurate data. We now have precise sales cycle work.

@gmbelart
Copy link

Hello @pratu16x7 , i finally tested multiselect. I had been create around 100 invoices with this feature. Everything works great. I will suggest one more correction when you find time for that. I found dificult when i have to search several DN. It will be useful to search DN, mark it and select another, and to have 2 selected DN, and still have options to search. Another solution is to create a button ''add'' in the form to insert DN to SI, and form for multiselect stay opened.
Without this you did a great job. This directly produce impact on productivity and Accurate data. We now have precise sales cycle work.

Any update for this? When I select item, and then search another item, my previous selected item are gone.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants