[fix] check all custom perms before adding permissions from standard docperm #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmehta
requested changes
May 12, 2017
frappe/permissions.py
Outdated
| @@ -330,7 +330,8 @@ def get_all_perms(role): | |||
| '''Returns valid permissions for a given role''' | |||
| perms = frappe.get_all('DocPerm', fields='*', filters=dict(role=role)) | |||
| custom_perms = frappe.get_all('Custom DocPerm', fields='*', filters=dict(role=role)) | |||
| doctypes_with_custom_perms = list(set(p.parent for p in custom_perms)) | |||
| all_custom_perms = frappe.get_all('Custom DocPerm', fields='parent') | |||
There was a problem hiding this comment.
why not select distinct parent from `tabCustom DocPerm ?
saurabh6790
force-pushed
the
role_permission_manager_display_fix
branch
from
f6df8ea
to
0c6bb1c
Compare
|
@rmehta Fixed!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After