Batch/Serial Number entry modal #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmehta
reviewed
May 23, 2017
frappe/public/js/frappe/form/grid.js
Outdated
| if(!idx) { | ||
| this.df.data.push({name: "batch " + (this.df.data.length+1), idx: this.df.data.length+1}); | ||
| } else { | ||
| // TODO |
|
ok for me. 👍. @mbauskar you can test and merge. |
Pull Request SummaryImage or animted GIF Not AddedPlease add an image or animated GIF as proof that you have manually tested this contribution. Hint: use LiceCAP to capture animated GIFs. Large PatchThis is a very large pull request, unless there is a very good reason, please try and break it down to smaller changes. Read this strategy on how it can be done Result
This summary was automatically generated based on this script |
rmehta
reviewed
Jun 19, 2017
| this.frm.script_manager.trigger(this.df.fieldname + "_add", d.doctype, d.name); | ||
| this.refresh(); | ||
| } else { | ||
| this.df.data.push({name: "batch " + (this.df.data.length+1), idx: this.df.data.length+1}); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With frappe/erpnext#8848