Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search translations bug #3318

Merged
merged 4 commits into from
May 19, 2017
Merged

search translations bug #3318

merged 4 commits into from
May 19, 2017

Conversation

almeidapaulopt
Copy link
Contributor

Fixes #3304

@pratu16x7
Copy link
Contributor

pratu16x7 commented May 16, 2017 •
edited

@almeidapaulopt Looks great. While the referenced issue sums up the problem well, you might want to include some screens of the result too as proof.
See https://github.com/frappe/erpnext/wiki/Contribution-Guidelines

@almeidapaulopt
Copy link
Contributor Author

searchproof
searchproof1

@rmehta rmehta merged commit e65b121 into frappe:develop May 19, 2017
@almeidapaulopt almeidapaulopt deleted the search_translate1 branch June 13, 2017 22:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search translations bug
3 participants
@almeidapaulopt @pratu16x7 @rmehta