Email praseaddr fix, fixes frappe/issues#3004 #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good stuff ;-) Looking forward to this getting merged soon. Thanks for this |
|
Thansk for the quick merge @rmehta ;-). I raised the original github issue but it got closed as did another of mine. I've been told that the originator can reopen Github issues but I can't see how this can be done. Could you advise pls? Many thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were few problems in parseaddr while parsing strings, a two-step verification is added to ensure that email address is extracted from the input string. Wrote a test case for verification.
Based on
#3004