Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email parse addr fix. #3371

Merged
merged 6 commits into from
Jun 7, 2017
Merged

Conversation

MCD-50
Copy link
Contributor

@MCD-50 MCD-50 commented May 23, 2017

The main problem was email_id was not getting fetched from string address string which was solved in last pull request. Now added a filter to name also which will remove email_id from email address string and remove all special characters from email address string and email address string will be assigned to name.

Example:
parse_addr('Surname, Name <name.surname@domain.com>')
// output (name: Surname Name, email: name.surname@domain.com)

All special characters will be removed from name string.

@rmehta
Copy link
Member

rmehta commented May 23, 2017

test case?

@joolsr
Copy link

joolsr commented May 23, 2017

Thanks - I hope we can get this committed soon. I am happy to run some further tests on this. In Europe the use of Surname, firstname email@email.com is very often used on the continent especially.

@joolsr
Copy link

joolsr commented May 23, 2017

Does this also mean with your fix that a contact if pre existing will be automatically shown against the doctype now, ie in an Opportunity when it wasn't before ?

@joolsr
Copy link

joolsr commented May 23, 2017

Out of interest, something similar is also required for email Subject lines. I had an email received by ERPNext that truncated the subject line as it had a £ symbol in it expressed as UTF-8. So everything after and including the £ symbol was lost from the subject. A minor point I know but worth making as you're looking at email handling now

Copy link
Contributor

@netchampfaris netchampfaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix codacy

@joolsr
Copy link

joolsr commented Jun 7, 2017

I cannot code, so cannot help with the further requirements needed here to get this committed to Develop. However I do raise issues, and help with Documentation as I can and in the forums ..

@MCD-50
Copy link
Contributor Author

MCD-50 commented Jun 7, 2017 via email

@netchampfaris netchampfaris merged commit e2de37b into frappe:develop Jun 7, 2017
@MCD-50 MCD-50 deleted the email-parse_addr branch June 14, 2017 10:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants