-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email parse addr fix. #3371
Email parse addr fix. #3371
Conversation
test case? |
Thanks - I hope we can get this committed soon. I am happy to run some further tests on this. In Europe the use of Surname, firstname email@email.com is very often used on the continent especially. |
Does this also mean with your fix that a contact if pre existing will be automatically shown against the doctype now, ie in an Opportunity when it wasn't before ? |
Out of interest, something similar is also required for email Subject lines. I had an email received by ERPNext that truncated the subject line as it had a £ symbol in it expressed as UTF-8. So everything after and including the £ symbol was lost from the subject. A minor point I know but worth making as you're looking at email handling now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix codacy
I cannot code, so cannot help with the further requirements needed here to get this committed to Develop. However I do raise issues, and help with Documentation as I can and in the forums .. |
We are trying to improve pull request quality that's why everytime I make pull request change is requested. If there is error in pull request it might down the entire system. Please be patient. And I know you don't know coding, please don't mention again and again.
Thanks. Sending new PR asap.
On Wed, Jun 7, 2017 at 2:48 PM +0530, "Julian Robbins" <notifications@github.com> wrote:
I cannot code, so cannot help with the further requirements needed here to get this committed to Develop. However I do raise issues, and help with Documentation as I can and in the forums ..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
The main problem was email_id was not getting fetched from string address string which was solved in last pull request. Now added a filter to name also which will remove email_id from email address string and remove all special characters from email address string and email address string will be assigned to name.
Example:
parse_addr('Surname, Name <name.surname@domain.com>')
// output (name: Surname Name, email: name.surname@domain.com)
All special characters will be removed from name string.