Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] Added columns field to Custom Field doctype #3469

Merged
merged 1 commit into from
Jun 13, 2017
Merged

[minor] Added columns field to Custom Field doctype #3469

merged 1 commit into from
Jun 13, 2017

Conversation

sagarvora
Copy link
Collaborator

Reference: frappe/erpnext#9233

Before:

selection_022

After:

selection_023

@mbauskar
Copy link
Contributor

mbauskar commented Jun 13, 2017 •
edited

@sagarvora,

Can you add the example for Sales Order/Item List with Columns value set as 4/5

Also please check if the columns field is available in the Customize Form

@mbauskar mbauskar closed this Jun 13, 2017
@sagarvora
Copy link
Collaborator Author

Before GIF

before columns

After GIF

columns testing

Hope this helps.

@sagarvora sagarvora reopened this Jun 13, 2017
@sagarvora sagarvora requested a review from mbauskar June 13, 2017 09:09
@rmehta rmehta merged commit 67ac932 into frappe:develop Jun 13, 2017
@rmehta
Copy link
Member

rmehta commented Jun 13, 2017

@sagarvora second one was much better!

@sagarvora sagarvora deleted the gh-9233 branch June 13, 2017 09:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbauskar mbauskar Awaiting requested review from mbauskar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sagarvora @mbauskar @rmehta