Add jinja support to leader_head.content and letter_head.footer #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add jinja support to leader_head.content and letter_head.footer
Considering that letter_head could be empty and cleaner code
ci2014
changed the title
rmehta
requested changes
Jun 16, 2017
frappe/www/printview.py
Outdated
| @@ -136,8 +136,14 @@ def get_template_from_string(): | |||
|
|
|||
| letter_head = frappe._dict(get_letter_head(doc, no_letterhead) or {}) | |||
|
|
|||
| if 'content' in letter_head: | |||
There was a problem hiding this comment.
should be if letter_head.content - letter_head will have a property content which can be None
There was a problem hiding this comment.
Thank you, that was my first aproach. I see you've changed it already.
Remove trailing whitespace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add jinja support to leader_head.content and letter_head.footer
As you can see, its working fine.