Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Enable overriding Quick Entry in custom app #3519

Merged
merged 5 commits into from Jun 26, 2017
Merged

[Feature] Enable overriding Quick Entry in custom app #3519

merged 5 commits into from Jun 26, 2017

Conversation

suyashphadtare
Copy link
Contributor

  1. Enable overriding Quick Entry in the custom app.

  2. Rewritten Quick entry function as Class.

  3. Above changes are done for overriding quick entry in ERPNext for creation of
    item variants from quick entry(considering item template already created).
    out123

  4. If PR gets merged will share ERPNext PR for the creation of item variants from Quick Entry.

@frappe-pr-bot
Copy link
Collaborator

Pull Request Summary

Image or animted GIF Not Added

Please add an image or animated GIF as proof that you have manually tested this contribution. Hint: use LiceCAP to capture animated GIFs.

Large Patch

This is a very large pull request, unless there is a very good reason, please try and break it down to smaller changes. Read this strategy on how it can be done

Result

  • Failed: User testing is mandatory for patches with changes in JS code.
  • Failed: Updating test cases is mandatory for large pull requests
  • Failed: User testing with animated GIF is mandatory for large pull requests.

This summary was automatically generated based on this script

@rmehta
Copy link
Member

rmehta commented Jun 23, 2017

👍 Will you also be sending the Item Variant Selector PR?

rmehta
rmehta reviewed Jun 23, 2017
View reviewed changes
Copy link
Member

@rmehta rmehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rename the controller to QuickEntryForm. otherwise looks okay!

frappe/public/js/frappe/form/quick_entry.js Outdated
var meta = frappe.get_meta(doctype);

var doc = frappe.model.get_new_doc(doctype, null, null, true);
frappe.ui.form.QuickEntryController = Class.extend({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just call it frappe.ui.form.QuickEntryForm

Its not a controller but a form

@suyashphadtare
Copy link
Contributor Author

  1. I have done necessary changes.
    Due to a non-fast-forward error during pushing to my repo, @mbauskar commit 8040e3224276220d836defd38244fdc9873b3867 has not been listing in my pull request as I have pushed forcefully. At primary check, everything seems okay. Please cross-check that.

  2. I will send Item Variant PR after merging of this PR.

@rmehta rmehta merged commit 17a43a4 into frappe:develop Jun 26, 2017
@suyashphadtare suyashphadtare mentioned this pull request Sep 13, 2017
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmehta rmehta rmehta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suyashphadtare @frappe-pr-bot @rmehta