Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email configurable footer #3584

Merged
merged 3 commits into from
Jul 3, 2017

Conversation

ashwinisave35
Copy link
Contributor

@ashwinisave35 ashwinisave35 commented Jun 29, 2017

Email footer content is added from system settings-> Email textfield

screen shot 2017-06-29 at 4 14 49 pm

System footer > Email -> Email Footer Address:

screen shot 2017-06-29 at 4 01 38 pm

Email Footer Test cases:

  1. If we haven't add data to Footer Address in System Settings and Checked the "Disable Standard Email Footer":
    Then there will be no footer

  2. If we added text to Footer Address in System Settings and Not checked "Disable Standard Email Footer":
    Then both footer are show ie. Custom footer from Footer Address and default footer "Sent via ERPNext"

  3. If no Footer address in System Settings and Not checked "Disable Standard Email Footer":
    Then default footer "Sent via ERPNext" shown in email footer.

Copy link
Contributor

@netchampfaris netchampfaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between divider and footer should be more.

@frappe-pr-bot
Copy link
Collaborator

Pull Request Summary

Image or animted GIF Not Added

Please add an image or animated GIF as proof that you have manually tested this contribution. Hint: use LiceCAP to capture animated GIFs.

Test Case Not Added / Updated

Since you have changed a Python file, you must update the relevant python test case. If there is no test coverage for this code, then please add it.


Result

  • Passed: Small Pull Request

This summary was automatically generated based on this script

@mbauskar mbauskar modified the milestone: 2017-07-05 Jun 30, 2017
@rmehta
Copy link
Member

rmehta commented Jun 30, 2017

  • Can you show what will come if there is no footer set by user?
  • Also how will footer come with unsubscribe link?
  • Also "Sent via ERPNext" should come by default

@rmehta rmehta merged commit 8ac396e into frappe:develop Jul 3, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants