Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] santize get_value, fixes frappe/erpnext#9561 #3624

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

rmehta
Copy link
Member

@rmehta rmehta commented Jul 6, 2017

field.get_value() and field.set_value() should always set and return the logical value, not the parsed or formatted value.

Now

field.get_value -> logical value
field.get_input_value -> input value

field.set_value -> set the logical value
field.set_input -> set in input

@rmehta rmehta merged commit 22bf250 into frappe:develop Jul 6, 2017
@rmehta rmehta deleted the santize-get-value branch February 6, 2019 06:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant