Pure Python MySQL instead mysqlclient (with Python C API) #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achillesrasquinha
changed the title
achillesrasquinha
changed the title
|
👍 is there a related PR in erpnext ? |
|
|
|
Why is UI failing? |
netchampfaris
approved these changes
Nov 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following:
We're done with our mysqlclient dependency. Primarily because it requires the Python C API (a 60 Mb package for most Linux Distros). This PR will address a complete port from mysqlclient to Pure Python MySQL. This hopefully wouldn't raise any sort of linking, or C dependencies required.
Related PR ERPNext