[fix] catch dropbox api malformed_path exception and log file path with traceback #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No way to fix the path?? |
rmehta
requested changes
Oct 18, 2017
| else: | ||
| dropbox_client.files_upload_session_append(f.read(chunk_size), cursor.session_id,cursor.offset) | ||
| cursor.offset = f.tell() | ||
| except dropbox.exceptions.ApiError: |
There was a problem hiding this comment.
you are catching all API Errors!
saurabh6790
force-pushed
the
catch_dropbox_malfile_path
branch
from
282a719
to
7b0170e
Compare
saurabh6790
force-pushed
the
catch_dropbox_malfile_path
branch
from
7b0170e
to
8620f5e
Compare
|
@rmehta Updated. |
rmehta
reviewed
Oct 18, 2017
| dropbox_client.files_upload_session_append(f.read(chunk_size), cursor.session_id,cursor.offset) | ||
| cursor.offset = f.tell() | ||
| except dropbox.exceptions.ApiError as e: | ||
| if isinstance(e.error, dropbox.files.UploadError): |
There was a problem hiding this comment.
you will have to import dropbox.files first, no?
Also why on directly except dropbox.files.UloadError: ?
There was a problem hiding this comment.
-
you will have to import dropbox.files first, no?
we have imported dropbox package, we can use directly -
Also why on directly except dropbox.files.UloadError:
As per dropbox docstring, in case of the exception, the method raises UploadError.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4296