Moved feed from Communication to Activity Log #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyashah115
force-pushed
the
activity
branch
from
cecdfda
to
34d1abc
Compare
shreyashah115
force-pushed
the
activity
branch
from
34d1abc
to
de299b4
Compare
rmehta
requested changes
Nov 10, 2017
| frappe.reload_doc("core", "doctype", "activity_log") | ||
|
|
||
| communication_data = frappe.get_all('Communication', filters= {'comment_type': 'Updated'}) | ||
| activity_log_field = frappe.get_meta('Activity Log').fields |
There was a problem hiding this comment.
Yeah, will change.
shreyashah115
force-pushed
the
activity
branch
7 times, most recently
from
adf0249
to
8814b10
Compare
rmehta
requested changes
Nov 14, 2017
| creation = frappe.db.get_value('Communication', {'name': d.name}, 'creation') | ||
| modified = frappe.db.get_value('Communication', {'name': d.name}, 'modified') | ||
|
|
||
| frappe.db.set_value('Activity Log', activity_doc.name, 'creation', creation) |
There was a problem hiding this comment.
should be just communication_doc.creation, no need to query again
shreyashah115
force-pushed
the
activity
branch
2 times, most recently
from
a9151ae
to
3a11a89
Compare
|
@rmehta Fixed! |
saurabh6790
requested changes
Nov 20, 2017
| activity_doc = frappe.get_doc(activity_data) | ||
| activity_doc.insert() | ||
|
|
||
| frappe.db.set_value('Activity Log', activity_doc.name, 'creation', communication_doc.creation) |
There was a problem hiding this comment.
why set_value?
Can't we set creation and modified datetime at the time of activity log creation?
frappe/model/delete_doc.py
Outdated
| @@ -276,6 +283,11 @@ def delete_dynamic_links(doctype, name): | |||
| set timeline_doctype=null, timeline_name=null | |||
| where timeline_doctype=%s and timeline_name=%s""", (doctype, name)) | |||
|
|
|||
| # unlink feed | |||
| frappe.db.sql("""update `tabActivity Log` | |||
There was a problem hiding this comment.
Does doctype, docname changes here?
If no then you can merge Unlink activity log and unlink feed together in single update query
shreyashah115
force-pushed
the
activity
branch
from
9cb04b3
to
a813b27
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4233
Summary:
comment_type == Updatedfrom Communication DocType.activity_log.activity_log.comment_type == Updatedare moved to Activity Log and deleted from Communication, along with the creation date and time.