Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize regex to find parent of mail #4440

Merged
merged 1 commit into from Nov 10, 2017
Merged

Conversation

ci2014
Copy link
Contributor

@ci2014 ci2014 commented Nov 6, 2017

Made the Regex case insensitive and changed the regex to show only the lowercase (which will save some space). Added the aw and wg for german answer and forwarding.

I will add more languages based on this list https://en.wikipedia.org/wiki/List_of_email_subject_abbreviations after more research.

EDIT: Any concerns about adding a field like that one "E-Mail prefixes" in the Language doctype and using those in the regex?

image

Made the Regex case insensitive and changed the regex to show only the lowercase (which will save some space). Added the aw and wg for german answer and forwarding.

I will add more languages based on this list https://en.wikipedia.org/wiki/List_of_email_subject_abbreviations after more research.
@rmehta rmehta merged commit 9d608d7 into frappe:develop Nov 10, 2017
@ci2014 ci2014 deleted the patch-9 branch November 10, 2017 09:31
@ci2014
Copy link
Contributor Author

ci2014 commented Nov 10, 2017

@rmehta Thanks for merging! Any feedback to this:

Any concerns about adding a field like that one "E-Mail prefixes" in the Language doctype and using those in the regex? This will give the users the ability to define them themselves.

@joolsr
Copy link

joolsr commented Nov 10, 2017

Can you explain what this will do exactly ?

@ci2014
Copy link
Contributor Author

ci2014 commented Nov 10, 2017

Sure. At the moment (after the patch) only english and german prefixes for forwarded mails and replies to mails are considered by the regex.

As there are users, which use other languages than german and english, we need to provide a way for the end user to define the email prefixes for his own language (or of the email program he uses).

The regex is for matching replies and forwarded mails by their subject and append them to the right document.

@joolsr
Copy link

joolsr commented Nov 10, 2017

@ci2014 Ok. Actually, although I speak English as we communicate with customers who respond in English but speak another language, their replies usually have the re or AW in their own language too.

@ci2014
Copy link
Contributor Author

ci2014 commented Nov 10, 2017

@joolsr Yes, that's what I mean. If we don't match by any possible language, it will create a new ticket instead of appending.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants