Wait for trigger promises to finish before save #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratu16x7
commented
Nov 14, 2017
| @@ -696,7 +702,9 @@ _f.Frm.prototype.save = function(save_action, callback, btn, on_error) { | |||
|
|
|||
| // let any pending js process finish | |||
| setTimeout(function() { | |||
There was a problem hiding this comment.
The setTimeout was left as is for present implementation.
|
Looks fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicated via: WN-SUP28944
If save is clicked before blurring a trigger-calling field, the trigger may or may not finish before the save, resulting in the trigger affected fields not getting updated.
The proposed pattern will require the trigger on the field to return a
Promise:This will cause save to wait for any leftover triggers (Also needs the freeze screen evidently):