Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Data Import Tool #4527

Merged
merged 2 commits into from Dec 7, 2017
Merged

[Fix] Data Import Tool #4527

merged 2 commits into from Dec 7, 2017

Conversation

Zlash65
Copy link
Contributor

@Zlash65 Zlash65 commented Nov 22, 2017

data-import-error

  1. Empty rows should be skipped
  2. Naming series column is mandatory but wasn't checked appropriately and generic error was thrown "Check format of file" - misleading error. Fixed naming series issue and throwing meaningful message.
    data-import-fix

@Zlash65 Zlash65 force-pushed the data-import branch 2 times, most recently from 0b12ed7 to dfe727e Compare November 22, 2017 11:43
@netchampfaris netchampfaris merged commit a0c1af4 into frappe:develop Dec 7, 2017
@Zlash65 Zlash65 deleted the data-import branch January 15, 2018 05:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@manassolanki manassolanki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zlash65 @netchampfaris @manassolanki @rmehta