Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Document not visible if workflow state it has is no longer present in the workflow #4530

Merged
merged 1 commit into from
Nov 29, 2017
Merged

[Fix] Document not visible if workflow state it has is no longer present in the workflow #4530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion frappe/public/js/frappe/model/workflow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ frappe.workflow = {
var state = doc[state_fieldname] ||
frappe.workflow.get_default_state(doctype, doc.docstatus);

var allow_edit = state ? frappe.workflow.get_document_state(doctype, state).allow_edit : null;
var allow_edit = state ? frappe.workflow.get_document_state(doctype, state) && frappe.workflow.get_document_state(doctype, state).allow_edit : null;

if(!frappe.user_roles.includes(allow_edit)) {
return true;
Expand Down