Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Trigger to display save on uncheck #4541

Merged
merged 2 commits into from Nov 29, 2017
Merged

[Fix] Trigger to display save on uncheck #4541

merged 2 commits into from Nov 29, 2017

Conversation

shreyashah115
Copy link
Contributor

@shreyashah115 shreyashah115 commented Nov 28, 2017 •
edited

frappe/erpnext#11743
Whenever a value 0 is passed in any form, it takes value as false, so changed the condition to value===undefined.

uncheck

shreyashah115 and others added 2 commits November 28, 2017 12:06
@shreyashah115
trigger save on uncheck
f3955fd
@rmehta
Update form.js
fe3f3c8 
the reason for this condition was text editor
@netchampfaris netchampfaris merged commit ce06601 into frappe:develop Nov 29, 2017
@shreyashah115 shreyashah115 deleted the uncheck branch November 29, 2017 07:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@netchampfaris netchampfaris netchampfaris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shreyashah115 @netchampfaris @rmehta